Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Max pin glue to 1.21.1 in v4.1.x #3402

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jan 21, 2025

Description

This pull request is to max pin glue-core in anticipation of #3238 . Also would fix devdeps. Only applies to v4.1.x backport branch as Ricky requested.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Jan 21, 2025
@pllim pllim added this to the 4.1.1 milestone Jan 21, 2025
@pllim pllim mentioned this pull request Jan 21, 2025
9 tasks
@pllim pllim force-pushed the max-pin-glue-so-sticky-v4.1.x branch from 2e6160d to db00ae3 Compare January 22, 2025 03:42
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (ae3063a) to head (fd6ac7c).
Report is 2 commits behind head on v4.1.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           v4.1.x    #3402      +/-   ##
==========================================
- Coverage   88.08%   88.08%   -0.01%     
==========================================
  Files         127      127              
  Lines       19595    19599       +4     
==========================================
+ Hits        17261    17263       +2     
- Misses       2334     2336       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: Kyle Conroy <[email protected]>
@pllim pllim merged commit 12d2b17 into spacetelescope:v4.1.x Jan 22, 2025
19 of 20 checks passed
@pllim pllim deleted the max-pin-glue-so-sticky-v4.1.x branch January 22, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants