Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Future-proof test_data_quality_plugin #3403

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jan 21, 2025

Description

This pull request is to future-proof test_data_quality_plugin as @bmorris3 suggested. Follow up of #3390 .

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive backport-v4.1.x on-merge: backport to v4.1.x labels Jan 21, 2025
@pllim pllim added this to the 4.1.1 milestone Jan 21, 2025
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Jan 21, 2025
against upstream DQ flag changes
@pllim pllim force-pushed the dq-test-futureproof branch from ba728b2 to c022d5c Compare January 22, 2025 03:43
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are unrelated, looks fine.

@pllim
Copy link
Contributor Author

pllim commented Jan 22, 2025

@rosteen you will have to use admin override to merge. Thanks!

@rosteen rosteen merged commit 4d1fa81 into spacetelescope:main Jan 22, 2025
18 of 19 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Jan 22, 2025
@pllim pllim deleted the dq-test-futureproof branch January 22, 2025 16:45
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.62%. Comparing base (ed09c31) to head (c022d5c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3403   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files         128      128           
  Lines       19844    19844           
=======================================
  Hits        17388    17388           
  Misses       2456     2456           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pllim added a commit that referenced this pull request Jan 22, 2025
…3-on-v4.1.x

Backport PR #3403 on branch v4.1.x (TST: Future-proof test_data_quality_plugin)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.1.x on-merge: backport to v4.1.x no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations testing trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants