-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Future-proof test_data_quality_plugin #3403
Conversation
against upstream DQ flag changes
ba728b2
to
c022d5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failures are unrelated, looks fine.
@rosteen you will have to use admin override to merge. Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3403 +/- ##
=======================================
Coverage 87.62% 87.62%
=======================================
Files 128 128
Lines 19844 19844
=======================================
Hits 17388 17388
Misses 2456 2456 ☔ View full report in Codecov by Sentry. |
…3-on-v4.1.x Backport PR #3403 on branch v4.1.x (TST: Future-proof test_data_quality_plugin)
Description
This pull request is to future-proof
test_data_quality_plugin
as @bmorris3 suggested. Follow up of #3390 .Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.