Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #3235 on branch v4.1.x (Bugfix: lcviz TPFs are sliced by cube index rather than time slice) #3405

Conversation

meeseeksmachine
Copy link

Backport PR #3235: Bugfix: lcviz TPFs are sliced by cube index rather than time slice

@lumberbot-app lumberbot-app bot added this to the 4.1.1 milestone Jan 22, 2025
@lumberbot-app lumberbot-app bot added plugin Label for plugins common to multiple configurations backport-v4.1.x on-merge: backport to v4.1.x labels Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.08%. Comparing base (ae3063a) to head (1b4f8a5).
Report is 1 commits behind head on v4.1.x.

Files with missing lines Patch % Lines
jdaviz/configs/cubeviz/plugins/mixins.py 73.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           v4.1.x    #3405      +/-   ##
==========================================
- Coverage   88.08%   88.08%   -0.01%     
==========================================
  Files         127      127              
  Lines       19595    19599       +4     
==========================================
+ Hits        17261    17263       +2     
- Misses       2334     2336       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry merged commit bae76e2 into spacetelescope:v4.1.x Jan 22, 2025
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.1.x on-merge: backport to v4.1.x cubeviz plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants