Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add instruction to update CITATION.cff after bugfix release #3422

Merged
merged 1 commit into from
Jan 31, 2025
Merged

add instruction to update CITATION.cff after bugfix release #3422

merged 1 commit into from
Jan 31, 2025

Conversation

cshanahan1
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the documentation Explanation of code and concepts label Jan 31, 2025
@cshanahan1 cshanahan1 added the no-changelog-entry-needed changelog bot directive label Jan 31, 2025
@cshanahan1 cshanahan1 added this to the 4.2 milestone Jan 31, 2025
pllim
pllim requested changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is already mentioned at the existing doc.

@cshanahan1
Copy link
Contributor Author

I think it is already mentioned at the existing doc.

it's missing in the bugfix section, it should be under step 7

@codecov Codecov
Copy link

codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.53%. Comparing base (4ffc3a0) to head (5bdecce).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3422   +/-   ##
=======================================
  Coverage   87.53%   87.53%           
=======================================
  Files         128      128           
  Lines       19957    19957           
=======================================
  Hits        17469    17469           
  Misses       2488     2488

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pllim
pllim approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I missed that this was specifically in bugfix section. LGTM. Sorry for the confusion. Thanks!

@pllim pllim merged commit aedb793 into spacetelescope:main Jan 31, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim approved these changes

@rosteen rosteen Awaiting requested review from rosteen rosteen is a code owner

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh is a code owner

@kecnry kecnry Awaiting requested review from kecnry kecnry is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay is a code owner

@gibsongreen gibsongreen Awaiting requested review from gibsongreen gibsongreen is a code owner

Assignees
No one assigned
Labels
documentation Explanation of code and concepts no-changelog-entry-needed changelog bot directive
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@cshanahan1 @pllim