Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin git dependencies to specific commits #413

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Oct 31, 2024

spacetelescope/romancal#1483

Tasks

  • Update or add relevant roman_datamodels tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (087a60d) to head (5a92b31).
Report is 100 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
+ Coverage   97.56%   97.72%   +0.16%     
==========================================
  Files          30       36       +6     
  Lines        2788     3431     +643     
==========================================
+ Hits         2720     3353     +633     
- Misses         68       78      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett marked this pull request as ready for review October 31, 2024 15:40
@zacharyburnett zacharyburnett requested a review from a team as a code owner October 31, 2024 15:40
@zacharyburnett zacharyburnett marked this pull request as draft October 31, 2024 16:01
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promote from draft, please. Otherwise, LGTM

@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Nov 1, 2024

oh sorry, did not add the update here: we're investigating whether SDP can just use --no-deps when installing from the requirements file. If they can add that to their install script (and I don't see why they wouldn't be able to) then that would obviate the need for this PR (and spacetelescope/romancal#1483)

@ddavis-stsci
Copy link
Collaborator

SDF can use the --no-deps option in the build so we can close this.

@zacharyburnett zacharyburnett deleted the pin/git_dependencies branch November 1, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants