Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on the apodized FFT interpolation #1017

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Turn on the apodized FFT interpolation #1017

merged 1 commit into from
Feb 8, 2024

Conversation

WilliamJamieson
Copy link
Collaborator

The original Goddard code effectively had this turned off, so in order to replicate those results this was turned off in romancal on purpose too even though was part of the Goddard code. This was reported to Goddard as a potential bug, and was confirmed to be a bug in the reference implementation by Goddard.

This PR enables the apodized FFT interpolation by default

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner November 20, 2023 17:06
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.81%. Comparing base (39d2f0b) to head (cdb50dd).
Report is 446 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1017   +/-   ##
=======================================
  Coverage   76.81%   76.81%           
=======================================
  Files         105      105           
  Lines        7048     7048           
=======================================
  Hits         5414     5414           
  Misses       1634     1634
Flag Coverage Δ *Carryforward flag
nightly 62.99% <ø> (ø) Carriedforward from 39d2f0b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly
Copy link
Collaborator

schlafly commented Jan 2, 2024

This looks good to me. It may also go through the regression tests fine since they have zeroed reference pixel channels, in which case we could go ahead and just merge it. Did you run the regression tests?

@WilliamJamieson WilliamJamieson force-pushed the bugfix/refpix branch 2 times, most recently from 5cfd63f to 93caa38 Compare February 1, 2024 19:09
@WilliamJamieson
Turn on the apodized FFT interpolation
cdb50dd 
The original Goddard code effectively had this turned off,
so in order to replicate those results this was turned off here
too even though was part of the Goddard code.
This was reported to Goddard as a potential bug, and was confirmed to
be a bug in the reference implementation, so it should be turned
on by default.
@WilliamJamieson
Copy link
Collaborator Author

This in fact passes the regression tests currently because amp33 is set to zero in those, see: https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/597/

@schlafly
Copy link
Collaborator

schlafly commented Feb 8, 2024

Great. This is simple, approved by Goddard, and passes the regression tests; approving.

@WilliamJamieson WilliamJamieson merged commit 472aaf8 into spacetelescope:main Feb 8, 2024
30 checks passed
@WilliamJamieson WilliamJamieson deleted the bugfix/refpix branch February 8, 2024 15:03
mairanteodoro pushed a commit to mairanteodoro/romancal that referenced this pull request Feb 14, 2024
@WilliamJamieson @mairanteodoro
Turn on the apodized FFT interpolation (spacetelescope#1017)
79eea0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlafly schlafly schlafly approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilliamJamieson @schlafly