RCAL-509: Update jump step docs #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1035 +/- ##
=======================================
Coverage 70.94% 70.94%
=======================================
Files 105 105
Lines 6979 6979
=======================================
Hits 4951 4951
Misses 2028 2028
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
schlafly
reviewed
Dec 4, 2023
WilliamJamieson
force-pushed
the
feature/jump_docs
branch
from
8bb4c35 to
9b79415
Compare
schlafly
approved these changes
Dec 7, 2023
| If the uneven-ramp jump detection algorithm is turned on (the default), the ramp fitting | ||
| algorithm is then run iteratively on a "queue" (list) of ramps. The queue is initialized | ||
| with the ramp(s). | ||
| Then following the algorithm presented in Sanjib et al (2023) (in preparation), |
There was a problem hiding this comment.
Suggested change
| Then following the algorithm presented in Sanjib et al (2023) (in preparation), | |
| Then following the algorithm presented in Sharma et al (2023) (in preparation), |
WilliamJamieson
force-pushed
the
feature/jump_docs
branch
from
9b79415 to
363c928
Compare
WilliamJamieson
force-pushed
the
feature/jump_docs
branch
from
363c928 to
15e773a
Compare
ddavis-stsci
added a commit
to ddavis-stsci/romancal
that referenced
this pull request
Dec 11, 2023
Co-authored-by: Eddie Schlafly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-509
Closes #760
This PR adds documentation for the uneven jump detection algorithm.
Checklist
CHANGES.rstunder the corresponding subsection