-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for outlier detection step. #1042
Add docs for outlier detection step. #1042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good to me. There are a few leftover references to JWST that should probably be purged, though it's also probably virtuous to reference that the step's heritage is from Webb. I forget whether the TSO code remained in the step or not; if not, it probably doesn't belong in the docs.
@mairanteodoro What is the status of this? Is it ready to be moved out of Draft status? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1042 +/- ##
=======================================
Coverage 70.94% 70.94%
=======================================
Files 105 105
Lines 6979 6979
=======================================
Hits 4951 4951
Misses 2028 2028
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Yes, it is. Thanks for the reminder, @nden! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few, mostly minor comments, but I think it looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec section does not render nicely. The problem was solved in the jwst pipeline, see a PR from Brett
Done. Applied fix implemented in PR#8101. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
f531890
to
2f0cd4a
Compare
Resolves RCAL-503
This PR adds the documentation for the outlier detection step.
Successfully ran the regression tests, and the results are available here.
Checklist
CHANGES.rst
under the corresponding subsection