Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to outlier detection docs. #1062

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

mairanteodoro
Copy link
Collaborator

This PR updates two parameters from the outlier detection step (snr and scale) in order to match JWST (see JWST's PR#8177).

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@mairanteodoro mairanteodoro added documentation Improvements or additions to documentation no-changelog-entry-needed labels Jan 16, 2024
@mairanteodoro mairanteodoro requested a review from a team as a code owner January 16, 2024 15:20
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.72%. Comparing base (a45c47d) to head (f412dd6).
Report is 463 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1062   +/-   ##
=======================================
  Coverage   76.72%   76.72%           
=======================================
  Files         105      105           
  Lines        7015     7015           
=======================================
  Hits         5382     5382           
  Misses       1633     1633           
Flag Coverage Δ *Carryforward flag
nightly 63.02% <ø> (ø) Carriedforward from 6f78541

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mairanteodoro mairanteodoro merged commit 1c2c7d2 into spacetelescope:main Jan 18, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants