Determine crpix from saif toggle #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good @wbalmer, just some typos to fix.
Can you confirm you've tested this on the data you're working on for both of the cr_from_siaf cases?
|
Hi Aarynn - yep! I have tested the toggle behaves well when set false by default, when set false explicitly, and when set true explicitly. |
AarynnCarter
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #114 . For data affected by bad fits writing behavior, for instance, the NIRCam BAR/NARROW offset position, it might be necessary to toggle calling the CRPIX values from pysaif, as opposed to recording them from the headers. This affects the position of the mask and therefore the coronagraphic throughput. Default behavior is unchanged and the toggle is set to false. Added to the appropriate functions in
database.pyPotential improvement could look to incorporate @JarronL 's
webbpsf_ext.imreg_tools.get_coron_apnamefunction in the default database building step, but this change is non-intrusive and sufficient for current reductions (unlike the original implementation in #114 ).