Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating requirements.txt #204

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Updating requirements.txt #204

merged 5 commits into from
Aug 7, 2024

Conversation

AarynnCarter
Copy link
Collaborator

@AarynnCarter AarynnCarter commented Jul 30, 2024

Pull request to resolve a few issues relating to our requirements file:

  • Update stimage to latest version, check for issues with CI
  • Define minimum version for packages based on personal current install

Resolves #168 and Resolves #165

@AarynnCarter AarynnCarter changed the title Converting to latest version of stimage Updating requirements.txt Jul 30, 2024
@mperrin mperrin added this to the Release 2.1.0 milestone Jul 31, 2024
@AarynnCarter AarynnCarter requested a review from mperrin August 5, 2024 19:53
@mperrin
Copy link
Collaborator

mperrin commented Aug 6, 2024

@AarynnCarter is this ready for review? I see you tagged me to review, but it's also still marked as a "Draft" PR only. I'll be happy to review but want to check it's ready first.

@AarynnCarter AarynnCarter marked this pull request as ready for review August 6, 2024 13:26
@AarynnCarter
Copy link
Collaborator Author

@mperrin Whoops, yes ready for a check.

Copy link
Collaborator

@mperrin mperrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One super tiny clarification query.

For pandoc is it intended to be >= or just >? Most of the others are written as >= I see.

@AarynnCarter
Copy link
Collaborator Author

Nice catch @mperrin! Just fixed that and will merge.

@AarynnCarter AarynnCarter merged commit f9f0854 into develop Aug 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revisit stsci.stimage version dependency after it gets updated Define minimum versions in requirements.txt
2 participants