Fix to read in files faster #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kglidic This looks good but there a CI error relating to pulling a file from CRDS. Could you take a look? I'm not sure why it's suddenly changed but could be an issue with a package updating / might mean the requirements needs updating. |
|
Hey @AarynnCarter, I just re-ran the check and it seemed to fix the issue |
AarynnCarter
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a database with MIRI files, this step can be quite time-consuming. The code reads the data in by default even when the NINTS keyword is populated in the header. I added an if/else condition to handle this more efficiently.