-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Calibrated Contrast Measurements #91
Merged
Merged
Changes from 31 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
a3dc64b
Adding masking of MIRI FQPM edges for contrast curves
AarynnCarter a53739a
Converting pyfits to fits
AarynnCarter 07f5f4b
Removing SpaceTelescope Data class
AarynnCarter abf970b
Source injection working for calibrated contrast
AarynnCarter 141e1ab
Adding ability to inject and recover companion fluxes
AarynnCarter a3c6fc9
Adding determination of calibrated contrast curves
AarynnCarter d4da01a
Minor bug fixes
AarynnCarter 92da1df
Small plotting change
AarynnCarter 8087192
Merge branch 'develop' into calcon
mperrin f675740
Merge branch 'develop' into calcon
AarynnCarter d5850be
Merge branch 'calcon' of https://github.com/kammerje/spaceKLIP into c…
AarynnCarter 6218033
Adjust to use os.path.splitext()
AarynnCarter 11fdf6b
Adjust to use os.path.splitext()
AarynnCarter 2696fb1
Adding function to set pixels surrounded by NaNs to desired value.
AarynnCarter 8365553
Adjusting raw contrast print statement
AarynnCarter 2379f94
converting from hardcoded 6.5 to JWST_CIRCUMSCRIBED_DIAMETER
AarynnCarter 6c89911
Adding print statement for injection and recovery
AarynnCarter e754d1b
Minor documentation changes
AarynnCarter 8482f7c
Reformat ax.scatter() call
AarynnCarter 1674713
Removing conflicts
AarynnCarter fa44290
Ensuring everything is in arcseconds
AarynnCarter 489b2c2
Changing to WebbPSF for MIRI filter info
AarynnCarter 5a75647
making sure calcon works with latest version of develop + gitignore u…
AarynnCarter a06eb2a
Fixing bug when number of different KL modes == 1
AarynnCarter 662113f
Merge branch 'develop' into calcon
mperrin 5e10701
Merge branch 'develop' into calcon
mperrin af0df19
add more log statements and printed notification of files saved; also…
mperrin b5073a0
debug and enhance plotting code for raw and cal contrast
mperrin f6e903c
add plot title annotation of PSF subtraction strategy
mperrin 45b1041
trivial bug fix, add missing 'self.'
mperrin b525077
Tutorial updates for calcon branch with working raw and calibrated co…
mperrin 7b566ac
Adjusting install to jwst_new
AarynnCarter 3ceda4a
Merge branch 'calcon' of https://github.com/kammerje/spaceKLIP into c…
AarynnCarter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1,415 changes: 1,059 additions & 356 deletions
1,415
docs/source/tutorials/tutorial_NIRCam_contrast_analyses.ipynb
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,5 +4,6 @@ jdaviz | |
jwst | ||
matplotlib | ||
numpy | ||
pysynphot | ||
scipy | ||
webbpsf |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would urge you to reconsider this dependency, since
pysynphot
is deprecated and no longer actively developed. Insteadsynphot
should be preferred as the current tool, with similar but slightly different API after a refactoring.synphot
is actively developed and supported.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And yes, this is an annoyance from upstream, but wanted to make sure you were aware.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is tied to the
psf.py
file, which is built upon WebbPSF_ext. I 100% agree we should change, but don't want to bloat this PR further / I think this will need a careful hand to make sure we don't break anything. Instead, I've made a new issue so that we don't lose track.