JP-3248: Add ref file data model and step keywords for new MIRI EMI correction #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
==========================================
+ Coverage 64.75% 64.77% +0.02%
==========================================
Files 102 103 +1
Lines 5674 5687 +13
==========================================
+ Hits 3674 3684 +10
- Misses 2000 2003 +3 ☔ View full report in Codecov by Sentry. |
hbushouse
reviewed
Sep 7, 2023
I have not opened a PR in data models for this yet because I thought I needed a reference file example to see what needs to be read/written and how, is this correct? |
penaguerrero
force-pushed
the
emicorr
branch
2 times, most recently
from
a7d77a1 to
e0711a5
Compare
hbushouse
reviewed
Nov 3, 2023
penaguerrero
force-pushed
the
emicorr
branch
from
7127bda to
be022a1
Compare
hbushouse
reviewed
Nov 21, 2023
|
@mwregan2 If you concur that the ref file schema has all the appropriate entries/definitions for what's needed in the ref file, I think we can go ahead and merge this (once the few formatting issues are fixed) and hence make it available in master branch of stdatamodels. |
braingram
reviewed
Nov 21, 2023
braingram
reviewed
Nov 21, 2023
penaguerrero
force-pushed
the
emicorr
branch
from
a299a31 to
5e5e077
Compare
hbushouse
reviewed
Nov 30, 2023
hbushouse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3248
Resolves RCAL-nnnn
Closes #
This PR addresses the creation of a new step to correct MIRI images for EMI contamination.
Checklist
CHANGES.rst(either inBug FixesorChanges to API)