add erfa to devdeps #236
Closed
add erfa to devdeps #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
added
no-changelog-entry-needed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
=======================================
Coverage 64.70% 64.70%
=======================================
Files 102 102
Lines 5666 5666
=======================================
Hits 3666 3666
Misses 2000 2000 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The devdeps jobs are failing on the main branch due to testing against numpy 2.0 with the released version of erfa (which is build against numpy<2.0).
This PR updates the dev requirements to install the erfa pre-release (built against numpy 2.0).
This hit the same drizzle dependency issue as discussed in spacetelescope/jwst#7910