Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update warning filters in tests for pytest 8 #245

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

braingram
Copy link
Collaborator

pytest 8 includes a change to how "pytest.warns" behaves (it now re-emits non-matched warnings). Running the stdatamodels test suite against pytest 8 (rc1) there is one failing test test_ndarray_validation due to this change.

This PR updates the warning filters in test_ndarray_validation to work with pytest 8.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@braingram braingram added the no-changelog-entry-needed Trivial change that doesn't need an entry in the change log label Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee53eab) 0.00% compared to head (0a21094) 64.84%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #245       +/-   ##
===========================================
+ Coverage        0   64.84%   +64.84%     
===========================================
  Files           0      103      +103     
  Lines           0     5694     +5694     
===========================================
+ Hits            0     3692     +3692     
- Misses          0     2002     +2002     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review January 8, 2024 19:20
@braingram braingram requested a review from a team as a code owner January 8, 2024 19:20
Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@braingram braingram merged commit 1f2acf6 into spacetelescope:master Jan 22, 2024
22 checks passed
@braingram braingram deleted the pytest_8_wawrnings branch January 22, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed Trivial change that doesn't need an entry in the change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants