Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3520: Add ngroups to mask schema #249

Merged
merged 1 commit into from
Jan 24, 2024
Merged

JP-3520: Add ngroups to mask schema #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ Changes to API
Other
-----

-
- Add ``ngroups`` keyword to ``mask`` schema to match
parkeys on crds [#249]

1.9.0 (2023-12-11)
==================
Expand Down
1 change: 1 addition & 0 deletions src/stdatamodels/jwst/datamodels/schemas/mask.schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ allOf:
- $ref: keyword_exptype.schema
- $ref: keyword_readpatt.schema
- $ref: keyword_preadpatt.schema
- $ref: keyword_ngroups.schema
- type: object
properties:
dq:
Expand Down
2 changes: 1 addition & 1 deletion src/stdatamodels/jwst/datamodels/tests/test_schema_against_crds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def test_crds_selectors_vs_datamodel(jail_environ, instrument):
# No need to actually load the reference file into the datamodel!
with ref_model() as m:
for key in parkeys:
assert len(m.search_schema(key.lower())) > 0
assert len(m.search_schema(key.lower())) > 0, f"{f} missing {key} required by {r.basename}"
break
except IrrelevantReferenceTypeError as e:
log.debug(e)
Expand Down
Loading