JP-3520: Add ngroups to mask datamodel #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Any objection to #249 (it adds a formatted string to the test to hopefully provide some breadcrumbs to lead us to the offending file/parkey) |
🤦 No idea how I missed that! I'll attach your PR to the JP ticket and close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3520
This PR addresses an issue found in tests for JP-3519 - recent updates to the CRDS selection criteria for MIRI MRS bad pixel masks caused test failures due to the lack of these updates being applied to the datamodel.
Checklist
CHANGES.rst(either inBug FixesorChanges to API)