Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.10 support #392

Merged
merged 7 commits into from
Feb 4, 2025
Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Feb 3, 2025

Now that jwst has dropped 3.10 this package can drop 3.10 (per SPEC 0).

This PR:

  • drops python 3.10 support
  • increases the numpy and astropy minimum versions (by SPEC 0)
  • updates the CI and docs removing 3.10 usage

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@braingram braingram changed the title Drop py310 Drop python 3.10 support Feb 3, 2025
@braingram braingram marked this pull request as ready for review February 3, 2025 16:11
@braingram braingram requested a review from a team as a code owner February 3, 2025 16:12
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.17%. Comparing base (788f7bd) to head (18d18bd).
Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #392       +/-   ##
===========================================
+ Coverage   67.59%   78.17%   +10.57%     
===========================================
  Files         115      115               
  Lines        5932     5145      -787     
===========================================
+ Hits         4010     4022       +12     
+ Misses       1922     1123      -799     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emolter
Copy link
Contributor

emolter commented Feb 3, 2025

The tomli additional dependency here can also be removed: see https://github.com/codespell-project/codespell?tab=readme-ov-file#using-a-config-file

@emolter emolter requested a review from tapastro February 3, 2025 20:33
@emolter
Copy link
Contributor

emolter commented Feb 3, 2025

Sorry I should have looked more closely, there are other instances that are removable as well:
https://github.com/search?q=repo%3Aspacetelescope%2Fstdatamodels%20tomli&type=code

Noticed this because we also didn't remove them yet for jwst - I submitted a follow-up PR to do so.

@braingram braingram merged commit 36f4f33 into spacetelescope:main Feb 4, 2025
19 checks passed
@braingram braingram deleted the drop_py310 branch February 4, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants