Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Ginga upstream deprecation #236

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

ejeschke
Copy link
Collaborator

Description

Address upstream deprecation of the move_to() call on a Ginga canvas object

  • the move_to(x, y) call on a canvas object has been redefined in terms of move_to_pt((x, y)) since Ginga v2.6.5. move_to() has issued a DeprecationWarning since v4.0.0

  • this fixes the plugins to use move_to_pt(). It is compatible with Ginga back to v2.6.5

- the move_to(x, y) call on a canvas object has been redefined in terms
  of move_to_pt((x, y)) since Ginga v2.6.5.  move_to() has issued a
  DeprecationWarning since v4.0.0

- this fixes the plugins to use move_to_pt(). It is compatible with
  Ginga back to v2.6.5
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Appreciate it.

@pllim pllim merged commit d118bcd into spacetelescope:master Feb 22, 2024
11 checks passed
@ejeschke
Copy link
Collaborator Author

🙇‍♂️

@ejeschke ejeschke deleted the fixes-for-deprecations branch February 22, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants