Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
verbose
argument to Step and Pipeline which may fix issue #49.However, changing the logging level from DEBUG to CRITICAL also makes it impossible to record log messages (as you can see in the tests I use
record_logs
to check if there is any output). I am not sure if there is a way to prevent log messages from being output to the console and still record the logs.Another concern is that the
get_config_from_reference
class method uses the delegator logger instead of the logger created by the pipeline. This delegator logger cannot be controlled byverbose
before the pipeline is initiated. So some logs may still be output to the console.https://github.com/spacetelescope/stpipe/blob/9e7c4416fa8776c00843c18390a1dc2d7b4179d0/src/stpipe/pipeline.py#L143C11-L143C11
Although not good enough, this PR can still work as a workaround for those who do not want the logs printed to the console.