Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For coronagraph Lyot masks, add reference information on alignment per each mask #51

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented Dec 18, 2024

[relocated from https://github.com/spacetelescope/webbpsf/pull/675]

This PR implements a capability to have default mask alignment options (pupil_shift_x, pupil_shift_y, pupil_rotation) defined per each coronagraph mask. This is intended to allow WebbPSF to include measured in-flight information on the various masks.

Implementation details:

  • in constants.py add a dict which gives values of these options per each mask, or else None to leave undefined
  • in webbpsf_core.py, update code to look up and use those values.

WORK IN PROGRESS, NOT YET COMPLETE, NOT READY TO MERGE

@mperrin
Copy link
Collaborator Author

mperrin commented Dec 18, 2024

Make sure to also see the comment thread and discussion at spacetelescope/webbpsf#675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant