For coronagraph Lyot masks, add reference information on alignment per each mask #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[relocated from https://github.com/spacetelescope/webbpsf/pull/675]
This PR implements a capability to have default mask alignment options (
pupil_shift_x, pupil_shift_y, pupil_rotation
) defined per each coronagraph mask. This is intended to allow WebbPSF to include measured in-flight information on the various masks.Implementation details:
constants.py
add a dict which gives values of these options per each mask, or else None to leave undefinedwebbpsf_core.py
, update code to look up and use those values.WORK IN PROGRESS, NOT YET COMPLETE, NOT READY TO MERGE