Add rseth ezeth oracles #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-manuel
requested changes
Feb 11, 2025
src/EZETHExchangeRateOracle.sol
Outdated
| function latestAnswer() external view returns (int256) { | ||
| int256 ethUsd = ethSource.latestAnswer(); | ||
| (, , uint256 tvl) = oracle.calculateTVLs(); | ||
| int256 exchangeRate = int256(((tvl * 1e18) / ezETH.totalSupply())); |
There was a problem hiding this comment.
Suggested change
| int256 exchangeRate = int256(((tvl * 1e18) / ezETH.totalSupply())); | |
| ( ,, uint256 tvl ) = oracle.calculateTVLs(); |
There was a problem hiding this comment.
These diffs are weird, but I think you wanted the spacing fixed on the return calculate tvls value. Changed.
There was a problem hiding this comment.
int256(tvl * 1e18 / ezETH.totalSupply());
There was a problem hiding this comment.
ah wtf why did I put so many brackets. fixed
| } | ||
|
|
||
| function calculateTVLs() external view returns (uint256[][] memory , uint256[] memory, uint256 _exchangeRate) { | ||
| _exchangeRate = exchangeRate; |
There was a problem hiding this comment.
Suggested change
| _exchangeRate = exchangeRate; | |
| function calculateTVLs() external view returns (uint256[][] memory, uint256[] memory, uint256 _exchangeRate) { |
There was a problem hiding this comment.
Not sure what you want changed here.
There was a problem hiding this comment.
Hahah damn just uint256[][] memory , => uint256[][] memory, for first return param
test/EZETHExchangeRateOracle.t.sol
Outdated
| _exchangeRate = exchangeRate; | ||
| } | ||
|
|
||
| function totalSupply() external view returns (uint256) { |
|
Coverage after merging add-rseth-ezeth-oracles into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
lucas-manuel
approved these changes
Feb 12, 2025
lucas-manuel
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rsETH and ezETH are planned to be onboarded, so we need exchange rate oracles for them.