Remove Wire.begin() from begin()

sparkfun · Dec 30, 2020 · d2eda03 · d2eda03
1 parent ab32ea0
commit d2eda03
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/src/SparkFunBME280.cpp b/src/SparkFunBME280.cpp
@@ -71,17 +71,18 @@ uint8_t BME280::begin()
 
 	case I2C_MODE:
 
-		switch(_wireType)
-		{
-			case(HARD_WIRE):
-				_hardPort->begin(); //The caller can begin their port and set the speed. We just confirm it here otherwise it can be hard to debug.
-				break;
-			case(SOFT_WIRE):
-			#ifdef SoftwareWire_h
-				_softPort->begin(); //The caller can begin their port and set the speed. We just confirm it here otherwise it can be hard to debug.
-			#endif
-				break;
-		}
+		//Removing port begin from library. This should be done by user otherwise this library will overwrite Wire settings such as clock speed.
+		// switch(_wireType)
+		// {
+		// 	case(HARD_WIRE):
+		// 		_hardPort->begin(); //The caller can begin their port and set the speed. We just confirm it here otherwise it can be hard to debug.
+		// 		break;
+		// 	case(SOFT_WIRE):
+		// 	#ifdef SoftwareWire_h
+		// 		_softPort->begin(); //The caller can begin their port and set the speed. We just confirm it here otherwise it can be hard to debug.
+		// 	#endif
+		// 		break;
+		// }
 		break;
 
 	case SPI_MODE: