Integrate nokogiri-xmlsec into nokogiri #2888
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Definitely needs some work on how the library build works, and I think some #ifdefs to handle a range of xmlsec versions. Also seems to occasionally segfault running the test suite, so that definitely needs resolving first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
#2746 (comment)
Have you included adequate test coverage?
Tests have been ported over from the separate library, and some that were skipped
there have been fixed to be passing.
Does this change affect the behavior of either the C or the Java implementations?
This adds new functionality to the C implementation. In the draft version it doesn't
touch Java. We will either need Java to throw useful notimplemented exceptions or
add the features of this library to the Java side, presumably using a third-party library.
Additional Note
Definitely needs some work on how the bundled xmlsec build works, and I think some #ifdefs to handle a range of xmlsec versions. Also seems to occasionally segfault running the test suite, so that definitely needs resolving.