fix grid_lebedev() due to quadpy API changes #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the quadpy package for creating Lebedev spherical grids. quadpy API changed a lot meanwhile, so I tried to fixed this issue with this PR. The fix is not the nicest, since the current quadpy API handling with
quadpy.u3.get_good_scheme(degree)
does not fully cover all available Lebedev grids. Thus, I decided to use more lower level features calling lebedev_xxx() function directly, these functions should last longer as the upper part of the API. The API also changed the coordinate handling, it now returns cartesian coordinates. So our function must convert to az, colat, r. That's why I also copied the sph2cart and cart2sph routines from sfs toolbox into the util.pyWhat do you think? Thanks for suggestions and help.