Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for NumPy version 2 #1613

Merged
merged 20 commits into from
Feb 6, 2025
Merged

Adds support for NumPy version 2 #1613

merged 20 commits into from
Feb 6, 2025

Conversation

alexnick83
Copy link
Contributor

No description provided.

@havogt havogt mentioned this pull request Dec 19, 2024
Closed
@alexnick83 alexnick83 requested a review from tbennun February 5, 2025 14:14
tbennun
tbennun approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Very clean and captures the exact numpy 2 differences I was thinking of. I have one minor comment on a beta version in a test if you want to correct it.

tests/numpy/unop_test.py Outdated Show resolved Hide resolved
@alexnick83 alexnick83 enabled auto-merge February 6, 2025 15:05
@alexnick83 alexnick83 added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 5097d6f Feb 6, 2025
9 checks passed
@alexnick83 alexnick83 deleted the support-for-numpy-2 branch February 6, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexnick83 @tbennun