-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tutorial codegen #1925
Open
castigli
wants to merge
8
commits into
spcl:main
Choose a base branch
from
castigli:fix-tutorial-codegen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix tutorial codegen #1925
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c012697
fix codegen and add notebook test
castigli 86148e5
format
castigli 881042a
rename and add main
castigli 6b5d073
add nbconvert dep
castigli 13929d3
remove debug breakpoint
castigli d26d2e0
Update getting_started.ipynb
tbennun 0eb92da
remove explicit nb kernel
castigli 3f18387
add python kernel dependency for testing
castigli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
import nbformat | ||
import pytest | ||
from nbconvert.preprocessors import ExecutePreprocessor | ||
|
||
BASE_PATH = "tutorials/" | ||
NOTEBOOK_PATHS = [ | ||
f"{BASE_PATH}getting_started.ipynb", | ||
f"{BASE_PATH}codegen.ipynb", | ||
] | ||
|
||
|
||
@pytest.mark.parametrize("notebook", NOTEBOOK_PATHS) | ||
def test_notebook_exec(notebook): | ||
with open(notebook) as f: | ||
nb = nbformat.read(f, as_version=4) | ||
ep = ExecutePreprocessor(timeout=600) | ||
try: | ||
assert ep.preprocess(nb) is not None, f"Got empty notebook for {notebook}" | ||
except Exception: | ||
assert False, f"Failed executing {notebook}" | ||
|
||
|
||
if __name__ == '__main__': | ||
pytest.main(["-v", __file__]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please raise that exception. Otherwise we cannot know what went wrong. It will just raise an assertion error.