Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Indirect output communication #32

Closed
wants to merge 5 commits into from

Conversation

ziadhany
Copy link
Contributor

@ziadhany ziadhany commented Apr 8, 2023

issue: #15

@ziadhany ziadhany changed the title Indirect output communication Add support for Indirect output communication Apr 12, 2023
@ziadhany
Copy link
Contributor Author

@mcopik what do you think should be sent to the queue instead of the socket ( address, IP )?
and should all functions use config.client_channel.notify ?

@mcopik
Copy link
Collaborator

mcopik commented Apr 21, 2023

@ziadhany Thanks for the contribution! I was planning to work on this well since we need this feature ASAP.

This needs testing, but I would be happy to merge it into my PR #29 to a working branch before we merge it together to master. Can you please resolve issues described above? I think we can leave watch and heartbeat at the moment intact.

what do you think should be sent to the queue instead of the socket ( address, IP )?

Client ID, nothing else. In future, we will use that to handle multiple queues.

and should all functions use config.client_channel.notify ?

That would be the ultimate goal.

Add an initial AWS configuration for ClientChannelSQS
@ziadhany
Copy link
Contributor Author

This needs testing, but I would be happy to merge it into my PR #29 to a working branch before we merge it together to master.

ok, I will add some tests

Can you please resolve issues described above? I think we can leave watch and heartbeat at the moment intact.

sure, I will do my best to solve this issue 😀

@mcopik
Copy link
Collaborator

mcopik commented Apr 30, 2023

Hi @ziadhany! Thanks again for your help - I had to push the work on SQS since we need it for the release. I cherry-picked your SQS commits into the main branch and wrapped up the work merged in #29.

Thanks again for your help!

@mcopik mcopik closed this Apr 30, 2023
@ziadhany
Copy link
Contributor Author

Hi @ziadhany! Thanks again for your help - I had to push the work on SQS since we need it for the release. I cherry-picked your SQS commits into the main branch and wrapped up the work merged in #29.

Thanks again for your help!

@mcopik You are welcome! , I'm always happy to help out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants