Re-opening PR for Descriptive Titles #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I obviated this one by doing the same thing in a way that wouldn't drag performance down; no shade on you for not knowing the ins and outs of friggin Perl Mason and how it can be slowed in some ways. |
|
I get that Tabroom 3.0 is kind of in KTLO mode, but I don't think your changes really covered more than about 10% of my PR. I'll pick this back up on Tabroom 4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34
Re-opening since I don't trust my comment to a closed PR (#35 ) to not languish in an email inbox somewhere.
TLDR: I think more granular titles for webpages will be a big UI win.