-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wallet: add config setting "wallet_fullrbf" #8821
base: master
Are you sure you want to change the base?
Conversation
If a tx is a channel funding, it might be mutated by another instance of the same wallet, who does not know about that. |
I do not like the idea of adding another user setting, without a clear explanation of the use case for it, and how important that use case is, compared to other use cases.
|
Right. There is detailed discussion in #7072.
Well, tbh, I think we still need to distinguish between RBF (signalling) and non-RBF txs, because it is reliably possible to replace a signalling tx, which is probably not true for non-RBF.
|
note: if we decide that it is desirable to cancel channel funding transactions, then I think this should not be an option. |
This adds a config variable "wallet_fullrbf", which (if enabled) lets the user ignore the BIP-125 signalling rules and try to RBF any tx.
Because of the need to connect to an electrum server that sets
mempoolfullrbf=1
, and the related tx-propagation and miner-hashrate-fraction issue (as also mentioned in the config var description added here), this is atm not exposed to the GUI.related #8088 (comment)