Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnetic operation search #44

Merged
merged 9 commits into from
Jan 11, 2025
Merged

Magnetic operation search #44

merged 9 commits into from
Jan 11, 2025

Conversation

lan496
Copy link
Member

@lan496 lan496 commented Jan 11, 2025

Part of #33

@lan496 lan496 added the breaking-changes Incompatible with patch release label Jan 11, 2025
@lan496 lan496 force-pushed the magnetic-operation-search branch from 98cd22c to 437f89f Compare January 11, 2025 00:45
@lan496 lan496 force-pushed the magnetic-operation-search branch from 437f89f to 4f2e791 Compare January 11, 2025 00:59
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.58009% with 124 lines in your changes missing coverage. Please review.

Project coverage is 88.08%. Comparing base (0951fb6) to head (3b05a16).

Files with missing lines Patch % Lines
moyo/src/search/symmetry_search.rs 37.50% 50 Missing ⚠️
moyo/src/base/tolerance.rs 59.61% 21 Missing ⚠️
moyo/src/base/magnetic_cell.rs 77.77% 16 Missing ⚠️
moyo/src/search/primitive_symmetry_search.rs 95.49% 15 Missing ⚠️
moyo/src/base/operation.rs 75.00% 11 Missing ⚠️
moyo/src/search/primitive_cell.rs 96.20% 6 Missing ⚠️
moyopy/src/base.rs 0.00% 4 Missing ⚠️
moyo/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   89.42%   88.08%   -1.35%     
==========================================
  Files          32       35       +3     
  Lines        4510     4891     +381     
==========================================
+ Hits         4033     4308     +275     
- Misses        477      583     +106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lan496 lan496 merged commit ed5fc8e into main Jan 11, 2025
16 checks passed
@lan496 lan496 deleted the magnetic-operation-search branch January 11, 2025 01:07
@lan496 lan496 mentioned this pull request Jan 11, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-changes Incompatible with patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants