-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wording of versionadded
to neutral Added in [...]
instead of New in [...]
.
#12184
Conversation
Thanks for the ping, let me check with some others.
I'm not sure about this, nothing is rotting, it was new back then.
Is "Added in" more neutral than "New in"? Does it need to be?
Well this is true, but the distinction between "New in" and "Changed in" might be useful, compared with more similar "Added in" and "Changed in" being next to each othe. Plus we have some things like:
https://docs.python.org/3/library/itertools.html#itertools.accumulate Which would become:
|
This comment was marked as outdated.
This comment was marked as outdated.
I asked on the docs-community Discord, and the preference was for this change:
No objections from me :) Let's also ask a couple of theme maintainers, Furo's @pradyunsg and PyData Sphinx Theme's @trallard. |
From a user experience POV I'd advocate for consistency for example we have Aside, I think both |
Thank you @hugovk ! So, we have an example where the community has a different feeling than a maintainer 😄 I said -1 because the chaining of "Added" felt weird to me but I actually misunderstood the fact that the "Added the ..." is explicitly written (I missed the If people want a "new", maybe we could add a directive option for that / configuration value (and this could also help me in not breaking the translations, if any). Anyway, I will wait a bit more for feedback (say, a week) but I think I'll follow the community on that one. By the way, were there common arguments against the change? |
Nope, all were for the change! |
Do you want to have a look at it @chrisjsewell before I merge? |
yeh all good thanks, and thanks for the feedback @hugovk / @trallard interested in how we gather / record such feedback from the community, but that's for another time 😄 |
and also for this, I think it would be get to have the translations in the next release; but I believe this is kind of a "back-and-forth" between transifex , I definitely think this needs more explanation in the developer docs @picnixz maybe for now open a separate issue, to remind us to check these translations before release |
I'd love to discuss/brainstorm this! It will be good to have better ways to capture and coordinate user feedback and user experience improvements. |
I'm guessing you mean python/docs-community#78; not in person (I'm residing in Munich these days), but would be interested to drop by online or something |
Yes, that one! But happy to sync online. |
Resolves #11015.
@hugovk Do you think it is fine for Python docs?
@chrisjsewell Here I'm changing a localized string, hence possibly causing the same #11689. How should we deal with that? (we never fixed your issue by the way).