Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename spindb_api keyword arguments for consistency #2482

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

soininen
Copy link
Contributor

@soininen soininen commented Jan 11, 2024

This PR contains the Toolbox side changes of spine-tools/Spine-Database-API#334

Re spine-tools/Spine-Database-API#318

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

spinedb_api now uses 'entity_class_name' instead of 'class_name' in many places.

Re #318
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (99844fc) 63.72% compared to head (1537bab) 63.72%.
Report is 3 commits behind head on 0.8-dev.

Files Patch % Lines
...oolbox/spine_db_editor/widgets/graph_view_mixin.py 0.00% 2 Missing ⚠️
...olbox/spine_db_editor/widgets/add_items_dialogs.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           0.8-dev    #2482   +/-   ##
========================================
  Coverage    63.72%   63.72%           
========================================
  Files          195      195           
  Lines        35530    35530           
  Branches      6027     6027           
========================================
+ Hits         22642    22643    +1     
+ Misses       11699    11698    -1     
  Partials      1189     1189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit a2cd888 into 0.8-dev Jan 11, 2024
16 checks passed
@soininen soininen deleted the spinedb_api_318_consistent_field_names branch January 11, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants