Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random improvements to DB editor UX #3047

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

soininen
Copy link
Contributor

@soininen soininen commented Feb 12, 2025

  • The search bar editor used e.g. in Parameter value table now matches the search string to any position, not just the beginning. Parameters should now be a lot more discoverable as you can just type in 'cost' to get all parameters with 'cost' in their name.
  • The down key now adds a new row to some tables in DB editor making it faster to e.g. add new entities using the keyboard alone.

No associated issue.

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

CopyPasteTableView now inserts an extra row to the table
when the down key is pressed if its model is EmptyRowModel.
This is handy e.g. in Add Entities or Add Entity Classes dialogs
where, after giving a name for the current entity row, you just
press the down key to start adding another item.
Removed the "^" that was being added to the regex string
SearchBarEditor to allow matches at any position.
This improves discoverability of e.g. parameter name in
the Paramter values dock by a lot.
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 67.22%. Comparing base (4d5999a) to head (afefed7).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
spinetoolbox/widgets/custom_qtableview.py 33.33% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3047      +/-   ##
==========================================
- Coverage   67.24%   67.22%   -0.03%     
==========================================
  Files         194      194              
  Lines       37274    37284      +10     
  Branches     4472     4475       +3     
==========================================
- Hits        25064    25063       -1     
- Misses      10939    10950      +11     
  Partials     1271     1271              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit 434566b into master Feb 12, 2025
20 of 22 checks passed
@soininen soininen deleted the correct_cell_after_editing branch February 12, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant