Fix issues with database URL checks #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Data stores now get notified about dirty databases by a Qt signal in DB mngr simplifying the notification process considerably. This also fixes numerous issues stemming from the need to create a database mapping for the database before we actually check if the URL is OK. Re spine-tools/Spine-Toolbox#2930
soininen
force-pushed
the
2930_fix_ds_db_check
branch
from
4e20f63 to
895cea5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes numerous issues around having a Data store with invalid URL.
Fixes spine-tools/Spine-Toolbox#2930
Checklist before merging