Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new DB editor facilities in Toolbox #233

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

soininen
Copy link
Contributor

@soininen soininen commented Nov 1, 2024

Data stores are no longer responsible of Database editor's tab names. They merely register their names as candidates for database display names but it is up to Toolbox what it chooses to do with the information. This simplifies code and responsibilities in spine_items.

No associated issue.

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes in Toolbox repo have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 48.48485% with 17 lines in your changes missing coverage. Please review.

Project coverage is 62.84%. Comparing base (3b170a5) to head (8f1e282).

Files with missing lines Patch % Lines
spine_items/view/view.py 15.38% 11 Missing ⚠️
spine_items/data_store/data_store.py 68.42% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   62.81%   62.84%   +0.03%     
==========================================
  Files         168      168              
  Lines       17697    17709      +12     
  Branches     2048     2051       +3     
==========================================
+ Hits        11117    11130      +13     
  Misses       5989     5989              
+ Partials      591      590       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Data stores are no longer responsible of Database editor's tab
names. They merely register their names as candidates for
database display names but it is up to Toolbox what it chooses
to do with the information. This simplifies code and responsibilities
in spine_items.
@soininen soininen merged commit c7a0bb1 into master Nov 1, 2024
0 of 8 checks passed
@soininen soininen deleted the drop_codenames branch November 1, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant