Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file type filters to QFileDialogs based on selected tool type #241

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ptsavol
Copy link
Member

@ptsavol ptsavol commented Dec 20, 2024

Fixes spine-tools/Spine-Toolbox#2961

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes in Toolbox repo have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

@ptsavol ptsavol self-assigned this Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 63.02%. Comparing base (53e29bd) to head (6bb6b42).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...s/tool/widgets/tool_specification_editor_window.py 53.84% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
- Coverage   63.03%   63.02%   -0.02%     
==========================================
  Files         168      168              
  Lines       17959    17970      +11     
  Branches     2066     2069       +3     
==========================================
+ Hits        11320    11325       +5     
- Misses       6038     6042       +4     
- Partials      601      603       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptsavol ptsavol merged commit 053d22c into master Dec 20, 2024
8 of 10 checks passed
@ptsavol ptsavol deleted the tb_issue_2961 branch December 20, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get source file extension from tool type in Tool specifiation editor
1 participant