feat(manualjudgment): Select roles that can execute manual judgement … #7636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4792 Added ability to add roles to manual judgment stage. This is part of: spinnaker/spinnaker#4792. Enhanced stage.html to Get the roles of the application. Display the roles of the application as a list only if the stage is Manual Judgment. Enhanced stage.module.js to Fetch the permissions of the application from the gate application url. populate the list with only the roles of the application with no duplicates. Enhanced ApplicationReader.ts to Fetch the permissions of the application from the gate application url. Enhanced ManualJudgmentApproval.tsx to Fetch the roles of the application, stage and the user during the execution. Iterate through each of the user role to check if the role exists in the stage and application. If yes/no, enable/disable the continue button. Display the instruction that User does not have permissions to continue
|
Waiting for the feedback. |
This was referenced Dec 9, 2019
|
I assume this is waiting on spinnaker/governance#80 |
Yes, I believe so -- shall we close this for now? For changesets like this blocked by RFC approval (and coupled to a backend implementation that might change based on feedback on the RFC), would probably make sense to hold off on submitting the PR until the RFC has been merged, both to 1) encourage consensus on the RFC prior to implementation and 2) de-clutter Deck's open PRs. @christopherthielen what do you think? |
|
@sanopsmx going to close this for now since this has been sitting for a few months while we wait for approval of your RFC; please feel free to re-open once the RFC is approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#4792
Added ability to add roles to manual judgment stage.
This is part of: spinnaker/spinnaker#4792.
Enhanced stage.html to
Get the roles of the application.
Display the roles of the application as a list only if the stage is Manual Judgment.
Enhanced stage.module.js to
Fetch the permissions of the application from the gate application url.
populate the list with only the roles of the application with no duplicates.
Enhanced ApplicationReader.ts to
Fetch the permissions of the application from the gate application url.
Enhanced ManualJudgmentApproval.tsx to
Fetch the roles of the application, stage and the user during the execution.
Iterate through each of the user role to check if the role exists in the stage and application.
If yes/no, enable/disable the continue button.
Display the instruction that User does not have permissions to continue.