rfc(tracing): Adding Distributed Tracing to Spinnaker #345
Conversation
mattgogerly
requested review from
link108,
coleduclos,
dsanyika,
dbyron-sf,
rebalag,
guido9j and
praseedasathaye
as code owners
mattgogerly
force-pushed
the
distributed-tracing
branch
from
9d6021d to
dfedafa
Compare
| make broad improvements to logging. | ||
|
|
||
| This will be achieved by removing the `logback-defaults.xml` file from each service and including the Kork | ||
| equivalent in each service's source set, as described [here](https://stackoverflow.com/a/43686346). |
There was a problem hiding this comment.
This may change/get easier with the monorepo. I'd say the text here is fine.
rfc/distributed-tracing.md
Outdated
| Both [OpenTelemetry](https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/okhttp/okhttp-3.0/library) | ||
| and [Zipkin](https://github.com/openzipkin/brave/blob/master/instrumentation/okhttp3) provide instrumentation for OkHttp, | ||
| therefore we are free to choose. OpenTelemetry has been gaining a lot of momentum, but Brave is also widely used. | ||
| I leave this choice for discussion in this RFC. |
There was a problem hiding this comment.
I'm beginning to get educated here and am leaning to OpenTelemetry. Need to get more educated to form a proper preference.
|
This is exciting! Thank you @mattgogerly ! |
|
It turns out Micrometer Tracing doesn't support SpringBoot < 3.0, so we'll have to use Sleuth until we get there. I'll update the RFC accordingly. |
|
I've been playing around a bit and the proposed approach seems to work okay. Need to do a bit more testing to prove it out further. Need somebody with more knowledge of Gradle to confirm if we can include the Sleuth dependencies in kork-runtime rather than adding them as implementation dependencies to every service explicitly. |
Let's make troubleshooting easier.