Fix for size #4242
Merged
Fix for size #4242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if it is not used users can skip the output of the Deployment Manifest and Run Job (Manifest) stage by specifiying the attribute noOutput set to false in the stage json. This significantly reduces the execution context being saved in redis/databse or sent to the browser.
…Deployment Manifest or Run Job stage Most K8S deployments do not use the outputs in downstream stages. So, if it is not used users can skip the output of the Deployment Manifest and Run Job (Manifest) stage by specifiying the attribute noOutput set to false in the stage json. This significantly reduces the execution context being saved in redis/databse or sent to the browser.
link108
approved these changes
Mar 21, 2022
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
mattgogerly
reviewed
Mar 21, 2022
| @@ -76,6 +79,13 @@ public void taskGraph(@Nonnull StageExecution stage, @Nonnull TaskNode.Builder b | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public void afterStages(@Nonnull StageExecution stage, @Nonnull StageGraphBuilder graph) { | |||
| if (stage.getContext().getOrDefault("noOutput", "false").toString().equals("true")) { | |||
There was a problem hiding this comment.
Worth making this an equalsIgnoreCase (or a Boolean)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed PR Status Checks
#4032
Didn't have permissions to your branch so I forked to my own.