fix(azureOauth2): fixed oauth2 auth for azure custom config support #305
Conversation
Updated the oauth2 to work with azure oauth2 custom config, Added support for AuthCodeOptions options in config. Updated the auth workflow to open default browser with auth url. No need to copy past url and code from oauth2 redirect response. If the default browser doesn't work this fallbacks to printing url on console with instruction.
|
Hi! When this PR will be merged? Looking forward for it! |
|
Hi, is there a linked bug that would describe the behavior you're fixing? Does your config file still look like for what we have for example oauth: https://github.com/spinnaker/spin/blob/master/config/example.yaml#L25? I don't have experience with spin CLI and authenticating to azure so a little more context could help the review process, thanks! |
@Chinikins I have updated example config. This PR enables the advanced config for Oauth2. These are needed based on organizations oauth2 config. |
|
@gsapkal could you please resolve conflicts? |
Updated the oauth2 to work with azure oauth2 custom config, Added support for AuthCodeOptions options in config.
Updated the auth workflow to open default browser with auth url. No need to copy past url and code from oauth2 redirect response.
If the default browser doesn't work this fallbacks to printing url on console with instruction.