chore(java): Add some default runtime flags for java 17 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarulg
approved these changes
Nov 20, 2024
dbyron-sf
reviewed
Nov 20, 2024
| @@ -19,7 +19,11 @@ class SpinnakerApplicationPlugin implements Plugin<Project> { | |||
| appConvention.applicationDistribution.from(project.file("config/${appName}.yml")) { | |||
| into('config') | |||
| } | |||
| appConvention.applicationDefaultJvmArgs << "-Djava.security.egd=file:/dev/./urandom" | |||
| appConvention.applicationDefaultJvmArgs << "-Djava.security.egd=file:/dev/./urandom" + | |||
| // Required for some google SDK behavior when loading certs as part of creds | |||
There was a problem hiding this comment.
I'd really rather not do this. It's opening up holes that some folks don't need.
There was a problem hiding this comment.
It's... definitely more of a concern. We'd want to look but this right now impacts front50 and clouddriver. For any GCP communications. I'm open to other ideas on that - it's worth looking more if the google SDK has fixed this o NOT use the sun level APIs.
There was a problem hiding this comment.
Putting this in the individual repos that need it is better than putting it here.
There was a problem hiding this comment.
This plugin seems to overwrite any repo-specific JVM args defined in the build file. Somewhat tricky to handle per-repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables access to sun security stuff that google uses for a couple of cert loads. Will let other places doing PKI using sun stuff work using GCS storage or similar type configs.