- added the ability to pass parameters into Expression

spiral-modules · Feb 18, 2020 · d5cf2d4 · d5cf2d4
1 parent aa41484
commit d5cf2d4
Show file tree

Hide file tree

Showing 4 changed files with 82 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
 CHANGELOG for 0.9.0 RC
 ======================
 
+v2.7.9 (18.02.2020)
+-----
+- added the ability to pass parameters into Expression in operators and values
+
 v2.7.8 (18.02.2020)
 -----
 - added the ability to pass parameters into Expression

diff --git a/src/Driver/Compiler.php b/src/Driver/Compiler.php
@@ -12,6 +12,7 @@
 namespace Spiral\Database\Driver;
 
 use Spiral\Database\Exception\CompilerException;
+use Spiral\Database\Injection\Expression;
 use Spiral\Database\Injection\FragmentInterface;
 use Spiral\Database\Injection\Parameter;
 use Spiral\Database\Injection\ParameterInterface;

diff --git a/src/Driver/CompilerCache.php b/src/Driver/CompilerCache.php
@@ -237,10 +237,22 @@ protected function hashWhere(QueryParameters $params, array $where): string
             } elseif ($context[0] instanceof ParameterInterface) {
                 $hash .= $this->hashParam($params, $context[0]);
             } else {
+                if ($context[0] instanceof Expression) {
+                    foreach ($context[0]->getTokens()['parameters'] as $param) {
+                        $params->push($param);
+                    }
+                }
+
                 $hash .= $context[0];
             }
 
             // operator
+            if ($context[1] instanceof Expression) {
+                foreach ($context[1]->getTokens()['parameters'] as $param) {
+                    $params->push($param);
+                }
+            }
+
             $hash .= $context[1];
 
             if ($context[2] instanceof QueryInterface) {
@@ -249,6 +261,12 @@ protected function hashWhere(QueryParameters $params, array $where): string
             } elseif ($context[2] instanceof ParameterInterface) {
                 $hash .= $this->hashParam($params, $context[2]);
             } else {
+                if ($context[2] instanceof Expression) {
+                    foreach ($context[2]->getTokens()['parameters'] as $param) {
+                        $params->push($param);
+                    }
+                }
+
                 $hash .= $context[2];
             }
 
@@ -259,6 +277,12 @@ protected function hashWhere(QueryParameters $params, array $where): string
                 } elseif ($context[3] instanceof ParameterInterface) {
                     $hash .= $this->hashParam($params, $context[3]);
                 } else {
+                    if ($context[3] instanceof Expression) {
+                        foreach ($context[3]->getTokens()['parameters'] as $param) {
+                            $params->push($param);
+                        }
+                    }
+
                     $hash .= $context[3];
                 }
             }

diff --git a/tests/Database/SelectQueryTest.php b/tests/Database/SelectQueryTest.php
@@ -2377,4 +2377,57 @@ public function testSelectWithParametricExpression(): void
             $select
         );
     }
+
+    public function testSelectWithParametricExpression2(): void
+    {
+        $select = $this->database->select()
+            ->from(['users'])
+            ->where(
+                new Expression('RANGE(?, ?)', 101, 102),
+                '&&',
+                new Expression('RANGE(?, ?)', 103, 104)
+            );
+
+        $this->assertSameQuery(
+            'SELECT * FROM {users} WHERE RANGE(?, ?) && RANGE(?, ?)',
+            $select
+        );
+
+        $this->assertSameParameters(
+            [
+                101,
+                102,
+                103,
+                104
+            ],
+            $select
+        );
+    }
+
+    public function testSelectWithParametricExpression3(): void
+    {
+        $select = $this->database->select()
+            ->from(['users'])
+            ->where(
+                new Expression('RANGE(?, ?)', 101, 102),
+                new Expression('RANGE(name, ?)', 600),
+                new Expression('RANGE(?, ?)', 103, 104)
+            );
+
+        $this->assertSameQuery(
+            'SELECT * FROM {users} WHERE RANGE(?, ?) RANGE({name}, ?) RANGE(?, ?)',
+            $select
+        );
+
+        $this->assertSameParameters(
+            [
+                101,
+                102,
+                600,
+                103,
+                104
+            ],
+            $select
+        );
+    }
 }