Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro is not executed with non english words, no errors shown #22

Open
MADCATXXX opened this issue Jul 13, 2019 · 7 comments
Open

Macro is not executed with non english words, no errors shown #22

MADCATXXX opened this issue Jul 13, 2019 · 7 comments

Comments

@MADCATXXX
Copy link

MADCATXXX commented Jul 13, 2019

Example Macro:

/say hello
/script if not UnitExists("target") then print("script hello"); te=0; else te=1; end; sn="АБВ"; fn=IsSpellInRange
/targetenemy [noexists]
/say hello2
/script local localizedClass, englishClass = UnitClass("target"); print("script world")

line /say hello2 is not printed (script world is not printed too), the normal script is working ok. If I change АБВ to ABC everything is working.

I consider this bug top priority as the addon is literally broken for non-English clients.
It was working before patch 8.2.

@spiralofhope
Copy link
Owner

I see no changes that would apply in the 8.2.0 list
https://wow.gamepedia.com/Patch_8.2.0/API_changes

Perhaps there is something which refers to something in English which should instead perhaps use a non-localized number.

I will investigate.

@spiralofhope
Copy link
Owner

I cannot reproduce this issue. Do I understand correctly? What I did was:

  • create a button macro
    • I tested with a character macro, and a global macro
    • Just in case, I tested with the macro not in a folder, and in a folder
  • name it issue_22
  • pasted the example script
  • save the script
  • drag the button into my bars
  • select an npc
  • press the button
    • clicking and using a hotkey did the same thing

What I see is:

script world
[myname] says: hello
[myname] says: hello2

When I /cleartarget and try again, I see:

script hello
script world
[myname] says: hello
[myname] says: hello2

Maybe this problem exists only in a non-English client. I don't know how to get one, but I will learn.

@spiralofhope
Copy link
Owner

  • Within the launcher, I changed the game options for World of Warcraft, and changed the text language to Russian.
  • I run the game, and it is in Russian.

Is this the way you set your game?

I run the script, and it still works for me.

I don't understand what's happening. Have you tested with other addons disabled? My only other suggestion would be to back up your ./Account/YOURNAME/SavedVariables/SuperDuperMacro.lua and test again.

@MADCATXXX
Copy link
Author

My game client is Russian. I'll test it again today, and will make a video of the problem.

@MADCATXXX
Copy link
Author

MADCATXXX commented Jul 20, 2019

I made a quick video with the problem. "Super Duper Macro" addon was the only one enabled. No scripts or anything else was running.
Purpose of this macro is to print "hello2", it was edited down from a bigger one to display a problem.
Macro with saving variable value "ABC" is working ok (prints hello2), macro with saving variable value "АБВ" is not working and not printing "hello2".
Video is in FLV format with good compressing to keep file size to a minimum.
2019-07-20_193733931.zip
The main problem that there are no Lua errors and it was working ok before 8.2, so it's hard to debug the problem source. As I've said If this macro is saved as a usual macro (non SDM) - it works ok even with "АБВ" variable saving.

I'm also attaching my "super duper macro saved" variables:
SuperDuperMacro.zip
Global macros'es cache:
macros-cache-global.zip
Character macros'es cache:
macros-cache.zip

@MADCATXXX
Copy link
Author

If you need help debugging the problem - I can help with it. In this situation logging on every step of macro execution should help a lot.
Knowing Blizzard - error can be anywhere. I've had a problem with 1% of the user base of my addon. It than turned out that bitwise operations are calculated with errors on MAC OS client.
https://eu.battle.net/forums/en/wow/topic/7714092436
Blizzard didn't even respond to my bug, it was fixed only after 2 patches of WoW.

@spiralofhope
Copy link
Owner

I was experimenting with the example macro text (to use Cyrillic script) for #21

  • I made a regular SDM macro with your example macro text
  • I dragged it out as a button, and it worked correctly
  • I disowned it into a regular /macro (character specific) macro
  • I dragged it out as a/ button, and it then gave me:
script hello
script world
The number of messages that can be sent is limited, please wait to send another message.
[character] says: hello

.. but it only did this one time! I upgrade/downgraded the macro and tried it with both the default and the SDM versions and I cannot reproduce the error!

I don't think think this is related, but it was extremely interesting.

I know about an addon which can check the hidden macro communications channel, maybe that's a new way to look for SDM-related problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants