Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on attempting to claim a 19th character-specific macro #23

Open
spiralofhope opened this issue Jul 24, 2019 · 0 comments
Open
Assignees
Labels
⬇️ minor bug / ⤵️ low priority Throws an error that doesn't matter, or has a workaround.

Comments

@spiralofhope
Copy link
Owner

spiralofhope commented Jul 24, 2019

TL;DR the SDM window understand there are 18/18, so "claim" should just be greyed out..

This was discovered during exploration for #21


  • new character
  • disable addons
  • /macro > "<name> Specific Macros"
  • /sdm
  • move the SDM window next to the macro window
  • in sdm: New
    • Button Macro
    • Character-specific
    • Name: OVERWRITE_TEST
  • in the OVERWRITE_TEST macro, edit its text to be:

TESTING

in the /macro list..

  • switch to the "General Macros" tab, and then the "<name> Specific Macros" tab
  • (confirm the SDM macro appears. It cannot be clicked on)
  • New >
    • name it "1"
    • (don't bother choosing an icon)
    • (leave the content empty)
  • in the SDM list, for the OVERWRITE_TEST macro, click "Disown"
  • in the /macro list, click the macro you called 1
  • (confirm the SDM macro disappears from the /macro list.
  • in the SDM list, for the OVERWRITE_TEST macro, click "Claim"
  • in the /macro list, click the macro you called 1
  • (confirm the SDM macro re-appears in the /macro list.

Continue creating macros (even with the same name) until 17 are created, the entire macros list is full.

  • in the SDM list, for the OVERWRITE_TEST macro, click "Disown"
  • in the /macro list, click the macro you called 1
  • (confirm the SDM macro disappears from the /macro list.

Create one additional macro in the /macro list, so that it's full.

  • in the SDM list, for the OVERWRITE_TEST macro, click "Claim"
Click to expand ``` 1x [string "local macroIndex = sdm_GetMacroIndex(471)..."]:6: CreateMacro() failed, already have 120 macros [C]: in function `CreateMacro' [string "local macroIndex = sdm_GetMacroIndex(471)..."]:6: in main chunk [C]: in function `RunScript' ...faceSuperDuperMacro\SuperDuperMacro_Core.lua:406: in function `sdm_DoOrQueue' ...faceSuperDuperMacro\SuperDuperMacro_Core.lua:167: in function `sdm_MakeBlizzardMacro' ...faceSuperDuperMacro\SuperDuperMacro_Core.lua:277: in function `sdm_SetUpMacro' SuperDuperMacro\SuperDuperMacro_Interface.lua:93: in function

Locals:
(*temporary) = "OVERWRITE_TEST"
(*temporary) = "INV_MISC_QUESTIONMARK"
(*temporary) = "#sdm%&

Enter macro text here."

(*temporary) = true
(*temporary) = 1

</details>
@spiralofhope spiralofhope added the ⬇️ minor bug / ⤵️ low priority Throws an error that doesn't matter, or has a workaround. label Jul 24, 2019
@spiralofhope spiralofhope self-assigned this Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⬇️ minor bug / ⤵️ low priority Throws an error that doesn't matter, or has a workaround.
Projects
None yet
Development

No branches or pull requests

1 participant