Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Custom REST handlers documentation #1540

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

kkedziak-splunk
Copy link
Contributor

@kkedziak-splunk kkedziak-splunk commented Jan 22, 2025

Issue number:

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

Documentation changes for:

User experience

No changes.

Checklist

If an item doesn't apply to your changes, leave it unchecked.

@kkedziak-splunk kkedziak-splunk requested a review from a team as a code owner January 22, 2025 09:43
@kkedziak-splunk
Copy link
Contributor Author

Suggested pull request title: docs: add documentation for custom REST handlers configuration

I appreciate the well-structured and comprehensive documentation you've added for the REST handlers configuration options. The documentation is clear, includes good examples, and follows proper markdown formatting standards.

However, there are a few minor improvements that could make the documentation even better:

  1. In docs/options/rest_handlers.md:

    • Consider adding a brief introduction paragraph explaining what REST handlers are and when users might need custom ones
    • The table formatting could be improved by removing extra vertical bars to be consistent with other documentation
    • Consider adding a note about security implications of custom REST handlers
    • It might be helpful to add a complete example of a handler implementation file
  2. In docs/options/index.md:

    • Consider expanding the introduction to explain what the options section is used for in more detail
    • Add a note about where in the configuration hierarchy these options should be placed
  3. In mkdocs.yml:

    • The indentation of the new Options section could be aligned with other sections for better consistency

Despite these suggestions, the documentation is already quite thorough and ready to be merged. The examples are particularly helpful, and the parameter descriptions are clear and complete.

This comment was added by our PR Review Assistant Bot. Please kindly acknowledge that
while we're doing our best to keep these comments up to very high standards, they may occasionally be
incorrect. Suggestions offered by the Bot are only intended as points for consideration and no statements
by this bot alone can be considered grounds for merging of any pull request. Remember to seek a review
from a human co-worker.

To reply to the review and engage Review Bot in further conversation, start your comment with the words Review bot:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant