Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to choose own genius api access code #2152

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Conversation

j3bx
Copy link
Contributor

@j3bx j3bx commented Aug 4, 2024

Title

Added option to choose own genius api access code on config and cli

Description

Added the option to choose your own genius api in case the public one gets rate limited

Motivation and Context

When downloading lyrics from genius on my own I get rate limited very often, now imagine what happens when all are using the same api key!

How Has This Been Tested?

Untested

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

@j3bx
Copy link
Contributor Author

j3bx commented Aug 4, 2024

For some unknown reason there is an error in downloader.py line 196, which is already fixed on genius.py but it seems not to work as intended

@j3bx
Copy link
Contributor Author

j3bx commented Aug 19, 2024

It not workeing :(

@xnetcat
Copy link
Member

xnetcat commented Aug 19, 2024

It not workeing :(

I can merge this and fix this later one if that works for you. :)

@j3bx
Copy link
Contributor Author

j3bx commented Aug 19, 2024

Do as u wish, thank u for this project :D

@j3bx
Copy link
Contributor Author

j3bx commented Aug 19, 2024

But I'd like this to be implemented since I'm sure the shared genius api is not enough

@xnetcat xnetcat marked this pull request as ready for review August 21, 2024 03:30
@xnetcat xnetcat merged commit ed3c899 into spotDL:dev Aug 21, 2024
0 of 11 checks passed
@j3bx j3bx deleted the dev branch August 23, 2024 17:08
@xnetcat xnetcat mentioned this pull request Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants