Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metadata to Playlist Files #2215

Merged
merged 13 commits into from
Nov 14, 2024
Merged

Add Metadata to Playlist Files #2215

merged 13 commits into from
Nov 14, 2024

Conversation

PranjalSurana
Copy link
Contributor

Title

Add Metadata to Playlist Files

Description

Adding new setting to enhance the playlist (M3U) file generation by including #EXTINF metadata tag.

Related Issue

#2126

Motivation and Context

Enhancing playlist (M3U) file generation by including #EXTINF metadata tag . This would enrich the playlist files by including additional information like track duration and title, thereby providing a better user experience.

How Has This Been Tested?

Ran spotDL many times, to test various scenarios

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

xnetcat and others added 10 commits September 6, 2024 12:21
Bug fixes:
- Always include filter when sending requests to piped by @xnetcat 
- Check status code when getting response from piped by @xnetcat 
- Use piped.video instead of main piped instance by @j3bx in spotDL#2172
- Fixed `RuntimeError: Directory 'C:\Users\myuser\.spotdl\web-ui\dist' does not exist` by @R0GUE-A5H in spotDL#2173
- Make sync command aware of file name changes by @xnetcat 

Documentation:
- Chore: update downloader.py by @Elto

Co-authored-by: kuba <[email protected]>
Co-authored-by: Alan <[email protected]>
Co-authored-by: Ikko Eltociear Ashimine <[email protected]>
Co-authored-by: Ash <[email protected]>
@PranjalSurana
Copy link
Contributor Author

The failed pylint tests is failing, even though it shows "Your code has been rated at 10.00/10 (previous run: 10.00/10, -0.00)"
image

How should I address this?

@PranjalSurana
Copy link
Contributor Author

Also, failing test-vcr
image

If this url updated according to the assertion, other tests fail.

How should this be addressed?

@xnetcat
Copy link
Member

xnetcat commented Oct 21, 2024

Don't worry about tests, they are currently being improved. I will check this PR later today. Ping me so I don't forget :)

@xnetcat
Copy link
Member

xnetcat commented Oct 21, 2024

You should also add an cli argument

@PranjalSurana
Copy link
Contributor Author

Ok, so to enhance M3U file generation, I shld create a new CLI arg, and reuse the existing function for m3u in the new cli arg, rt?

@PranjalSurana
Copy link
Contributor Author

@xnetcat Can u plz recheck this PR, added new CLI arg

@Silverarmor Silverarmor changed the base branch from master to dev November 3, 2024 02:47
@Silverarmor
Copy link
Member

@PranjalSurana is there any reason not to simply change the default --m3u files to this enhanced version? Any downside? Don't see why we need another separate CLI arg for it

@PranjalSurana
Copy link
Contributor Author

@Silverarmor, I can use the default --m3u CLI arg, there is no downside to it.

@xnetcat xnetcat merged commit 1c110e7 into spotDL:dev Nov 14, 2024
2 of 11 checks passed
@xnetcat xnetcat mentioned this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants