Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md: Fixed link to AUR package #2227

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

inform880
Copy link
Contributor

@inform880 inform880 commented Nov 12, 2024

Title

Fixed link to AUR package in README

Description

Fixed link in docs to AUR package. Feel free to close if not needed.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

xnetcat and others added 2 commits September 6, 2024 12:21
Bug fixes:
- Always include filter when sending requests to piped by @xnetcat 
- Check status code when getting response from piped by @xnetcat 
- Use piped.video instead of main piped instance by @j3bx in spotDL#2172
- Fixed `RuntimeError: Directory 'C:\Users\myuser\.spotdl\web-ui\dist' does not exist` by @R0GUE-A5H in spotDL#2173
- Make sync command aware of file name changes by @xnetcat 

Documentation:
- Chore: update downloader.py by @Elto

Co-authored-by: kuba <[email protected]>
Co-authored-by: Alan <[email protected]>
Co-authored-by: Ikko Eltociear Ashimine <[email protected]>
Co-authored-by: Ash <[email protected]>
@inform880 inform880 changed the title Update README.md Update README.md: Fixed link to AUR package Nov 12, 2024
@Silverarmor Silverarmor changed the base branch from master to dev November 13, 2024 02:09
@Silverarmor Silverarmor merged commit 4137d1e into spotDL:dev Nov 13, 2024
1 of 11 checks passed
@Silverarmor
Copy link
Member

Tests failing are unrelated to this PR. Approved and merged.

@Silverarmor
Copy link
Member

@inform880 Do you know what happened with AUR and why the package changed name?

@AZMCode @pekkarr @aminvakil

@aminvakil
Copy link
Contributor

I can't find the comment regarding details of why

https://aur.archlinux.org/packages/spotdl?O=20#comment-964844

But as spotify-downloader is not a python library package to be used by other packages:

https://wiki.archlinux.org/title/Python_package_guidelines#Package_naming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants